Skip to content

[SPARK-10144] [UI] Actually show peak execution memory by default#8345

Closed
andrewor14 wants to merge 1 commit into
apache:masterfrom
andrewor14:show-memory-default
Closed

[SPARK-10144] [UI] Actually show peak execution memory by default#8345
andrewor14 wants to merge 1 commit into
apache:masterfrom
andrewor14:show-memory-default

Conversation

@andrewor14

Copy link
Copy Markdown
Contributor

The peak execution memory metric was introduced in SPARK-8735. That was before Tungsten was enabled by default, so it assumed that spark.sql.unsafe.enabled must be explicitly set to true. The result is that the memory is not displayed by default.

@andrewor14

Copy link
Copy Markdown
Contributor Author

@rxin @yhuai

@SparkQA

SparkQA commented Aug 21, 2015

Copy link
Copy Markdown

Test build #41338 has finished for PR 8345 at commit 5d3d81a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai

yhuai commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

LGTM.

asfgit pushed a commit that referenced this pull request Aug 24, 2015
The peak execution memory metric was introduced in SPARK-8735. That was before Tungsten was enabled by default, so it assumed that `spark.sql.unsafe.enabled` must be explicitly set to true. The result is that the memory is not displayed by default.

Author: Andrew Or <andrew@databricks.com>

Closes #8345 from andrewor14/show-memory-default.

(cherry picked from commit 662bb96)
Signed-off-by: Yin Huai <yhuai@databricks.com>
@asfgit asfgit closed this in 662bb96 Aug 24, 2015
@andrewor14 andrewor14 deleted the show-memory-default branch August 24, 2015 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants